Skip to content

New model - Keres - #7956

Open
EnderRobo wants to merge 4 commits into
beyond-all-reason:masterfrom
EnderRobo:ER-Keres
Open

New model - Keres#7956
EnderRobo wants to merge 4 commits into
beyond-all-reason:masterfrom
EnderRobo:ER-Keres

Conversation

@EnderRobo

@EnderRobo EnderRobo commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Work done

New model for Keres, script changes to work with the model, colvol changes to fit it better and a new unitpic.

BEFORE:

Screenshot 2026-06-14 170400

AFTER:

Screenshot 2026-06-14 170248

@EnderRobo EnderRobo changed the title New model and updated script + colvols New model - Keres Jun 14, 2026
@github-actions

github-actions Bot commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Integration Test Results

15 tests  ±0   7 ✅ ±0   4s ⏱️ ±0s
 1 suites ±0   8 💤 ±0 
 1 files   ±0   0 ❌ ±0 

Results for commit da37df0. ± Comparison against base commit a61e8a6.

♻️ This comment has been updated with latest results.

@EnderRobo
EnderRobo marked this pull request as ready for review June 14, 2026 15:23
@efrec efrec added Legion Issue related to Legion Script / Animation Units scripts, both BOS and LUS Unit Def Issues with unit definition files Modelling Issues with unit and feature models labels Jun 14, 2026
@efrec
efrec self-requested a review July 29, 2026 18:35
Comment thread scripts/Units/legkeres.bos

@efrec efrec left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This keeps some maybe-undesired behaviors, like the chainguns firing when out of arc. Is that intentional? Are we keeping that?

Fine if so. But I think we need to try to leave that up to the unitdef when we can. That can be put off to a new scope and out of this PR if you want.

Comment thread scripts/Units/legkeres.bos Outdated
@efrec

efrec commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

A couple of reflections and flat surfaces make the unit seem washed out in harsher lighting. This is partly not the model's issue, but probably can be handled better.

This one usually is unseen/unnoticed and is a large single reflective plane so stood out to me.
image

On this spout/exhaust, the issue is mostly with selection state:
image
image

@EnderRobo

Copy link
Copy Markdown
Contributor Author

This keeps some maybe-undesired behaviors, like the chainguns firing when out of arc. Is that intentional? Are we keeping that?

Fine if so. But I think we need to try to leave that up to the unitdef when we can. That can be put off to a new scope and out of this PR if you want.

This PR is just to change the model, any other changes should be in a seperate PR. The chainguns firing out of arc is an intended feature, but if it is undesired it can be removed

@EnderRobo

Copy link
Copy Markdown
Contributor Author

A couple of reflections and flat surfaces make the unit seem washed out in harsher lighting. This is partly not the model's issue, but probably can be handled better.

This one usually is unseen/unnoticed and is a large single reflective plane so stood out to me.

On this spout/exhaust, the issue is mostly with selection state:

Both of these seem to happen due to the selection state lighting, I cant really do anything about that as it affects all other colors the same (as can be seen in the third screenshot). This is more of an issue with either the rendering or the atlas, probably the rendering with the selection state lighting being very strong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Legion Issue related to Legion Modelling Issues with unit and feature models Script / Animation Units scripts, both BOS and LUS Unit Def Issues with unit definition files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants